-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate types json second try #2178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
changed the title
Feat/generate types json second try
generate types json second try
Oct 9, 2024
- Fix issue with releases due to the update of chain specs - Update the metadata comparison setup
shannonwells
temporarily deployed
to
github-pages
October 10, 2024 18:47
— with
GitHub Actions
Inactive
shannonwells
temporarily deployed
to
github-pages
October 10, 2024 21:46
— with
GitHub Actions
Inactive
wilwade
reviewed
Oct 11, 2024
Co-authored-by: Wil Wade <[email protected]>
shannonwells
temporarily deployed
to
github-pages
October 11, 2024 20:18
— with
GitHub Actions
Inactive
shannonwells
requested review from
wilwade,
a team,
mattheworris,
enddynayn,
aramikm,
claireolmstead and
JoeCap08055
and removed request for
a team
October 11, 2024 20:44
enddynayn
approved these changes
Oct 11, 2024
wilwade
approved these changes
Oct 11, 2024
saraswatpuneet
approved these changes
Oct 11, 2024
mattheworris
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read through changes
- Encountered local build error, so could not execute
make js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to generate a types.json file to help with being on Subscan et al. This is identical to the previous PR by the same name. It's an attempt to fix the problems with the release action via a new branch from main after the genesis issue was fixed.
You can see the list of artifacts with the test release here to check that it has the types.json file.
Download the js-api-augment built package here to check that it also has the types.json file (although the build of the release would have failed if it didn't)
Closes #2062
with @wilwade and @enddynayn
Checklist
make js
Verify
make js
, which replicates the two needed steps run in CI.cd js/api-augment/dist
, this should exist:json/types.json
types.json
should look like the following, so that it would be included in the tarball if you runnpm pack
: