revert: stalehash extension (#2184)

# Goal
The goal of this PR is <!-- insert goal here -->

Closes #2183 

Reverting #2137 


# Checklist
- [x] e2e Tests updated
- [X] Benchmarks updated
- [X] Spec version incremented?

e2e/stateful-pallet-storage/handleItemized.test.ts

@@ -180,10 +180,7 @@ describe('📗 Stateful Pallet Storage', function () {
         add_actions,
         0
       );
-      await assert.rejects(itemized_add_result_1.signAndSend('current'), {
-        name: 'RpcError',
-        message: /1010: Invalid Transaction: Custom error: 9/,
-      });
+      await assert.rejects(itemized_add_result_1.fundAndSend(fundingSource), { name: 'StalePageState' });
     });
   });
 
@@ -288,10 +285,7 @@ describe('📗 Stateful Pallet Storage', function () {
       };
       const remove_actions = [remove_action];
       const op = ExtrinsicHelper.applyItemActions(providerKeys, schemaId_deletable, msa_id, remove_actions, 0);
-      await assert.rejects(op.signAndSend('current'), {
-        name: 'RpcError',
-        message: /1010: Invalid Transaction: Custom error: 9/,
-      });
+      await assert.rejects(op.fundAndSend(fundingSource), { name: 'StalePageState' });
     });
   });
 

e2e/stateful-pallet-storage/handlePaginated.test.ts

@@ -202,8 +202,8 @@ describe('📗 Stateful Pallet Storage', function () {
 
       const paginated_add_result_1 = ExtrinsicHelper.upsertPage(providerKeys, schemaId, msa_id, page_id, payload_1, 0);
       await assert.rejects(paginated_add_result_1.signAndSend('current'), {
-        name: 'RpcError',
-        message: /1010: Invalid Transaction: Custom error: 9/,
+        message: 'Target page hash does not match current page hash',
+        name: 'StalePageState',
       });
     });
   });
@@ -232,22 +232,6 @@ describe('📗 Stateful Pallet Storage', function () {
         section: 'statefulStorage',
       });
     });
-
-    it('🛑 should fail call to remove page for un-delegated attempts', async function () {
-      const paginated_add_result_1 = ExtrinsicHelper.removePage(providerKeys, schemaId, badMsaId, 0, 0);
-      await assert.rejects(paginated_add_result_1.fundAndSend(fundingSource), {
-        name: 'UnauthorizedDelegate',
-        section: 'statefulStorage',
-      });
-    });
-
-    it('🛑 should fail call to remove page with stale target hash', async function () {
-      const paginated_add_result_1 = ExtrinsicHelper.removePage(providerKeys, schemaId, msa_id, 0, 1000);
-      await assert.rejects(paginated_add_result_1.signAndSend('current'), {
-        name: 'RpcError',
-        message: /1010: Invalid Transaction: Custom error: 9/,
-      });
-    });
   });
 
   describe('Paginated Storage RPC Tests', function () {

node/cli/src/benchmarking.rs

@@ -13,7 +13,6 @@ use sp_core::{Encode, Pair};
 use sp_keyring::Sr25519Keyring;
 use sp_runtime::{OpaqueExtrinsic, SaturatedConversion};
 
-use frequency_runtime::StaleHashCheckExtension;
 use pallet_balances::Call as BalancesCall;
 use pallet_msa;
 use sp_inherents::InherentDataProvider;
@@ -133,7 +132,6 @@ pub fn create_benchmark_extrinsic(
 		pallet_frequency_tx_payment::ChargeFrqTransactionPayment::<runtime::Runtime>::from(0),
 		pallet_msa::CheckFreeExtrinsicUse::<runtime::Runtime>::new(),
 		pallet_handles::handles_signed_extension::HandlesSignedExtension::<runtime::Runtime>::new(),
-		StaleHashCheckExtension,
 		frame_metadata_hash_extension::CheckMetadataHash::<runtime::Runtime>::new(false),
 		cumulus_primitives_storage_weight_reclaim::StorageWeightReclaim::<runtime::Runtime>::new(),
 	);
@@ -151,7 +149,6 @@ pub fn create_benchmark_extrinsic(
 			(),
 			(),
 			(),
-			(),
 			None,
 			(),
 		),