Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo (dhcp6 -> dhcpv6) #427

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Fix typo (dhcp6 -> dhcpv6) #427

merged 1 commit into from
Apr 7, 2024

Conversation

jwgn
Copy link
Contributor

@jwgn jwgn commented Apr 4, 2024 •
edited
Loading

Compile tested: No.
Run tested: No.

Description of your changes:

dhcp6 is not a valid protocol. It should be dhcpv6. This fixes the error Unsupported protocol type. in LuCi.

Akira25
Akira25 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@Akira25 Akira25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much for the contribution.

@Akira25
Copy link
Member

Akira25 commented Apr 7, 2024

One thing before merging this:

grafik

Could you please edit your commit message accordingly? The Package name should be freifunk-berlin-network-defaults and the signed-off-line is given in the picture.

@jwgn jwgn force-pushed the master branch 2 times, most recently from 7f05e9c to 0661abf Compare April 7, 2024 11:05
@jwgn jwgn requested a review from Akira25 April 7, 2024 17:04
@Akira25 Akira25 merged commit d2094f9 into freifunk-berlin:master Apr 7, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akira25 Akira25 Awaiting requested review from Akira25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwgn @Akira25