Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E Tests for Asset Teleportation Between LAOS and Asset Hub with Configuration Updates #829

Merged
merged 99 commits into from
Nov 13, 2024

Conversation

magecnion
Copy link
Contributor

@magecnion magecnion commented Oct 22, 2024

PR Type

Tests, Enhancement


Description

  • Added comprehensive end-to-end tests for teleporting assets between LAOS and Asset Hub, including steps for creating and minting foreign assets, and liquidity pool operations.
  • Updated XCM configuration to use HereLocation instead of RelayLocation.
  • Enhanced utility functions for XCM operations and event handling in the test suite.
  • Updated Zombienet configuration to include Asset Hub and enhanced logging.
  • Updated dependencies and test configurations in package.json.
  • Adjusted GitHub Actions workflow to include Asset Hub command setup.

Changes walkthrough 📝

Relevant files
Enhancement
3 files
xcm_config.rs
Update XCM configuration to use HereLocation                         

runtime/laos/src/configs/xcm_config.rs

  • Removed RelayLocation parameter.
  • Replaced RelayLocation with HereLocation in Trader type.
  • +1/-3     
    util.ts
    Add utility functions for XCM and event handling                 

    e2e-tests/tests/util.ts

  • Added utility functions for XCM operations and event handling.
  • Introduced functions for block change waiting and balance transfer.
  • +321/-15
    download_polkadot.sh
    Add polkadot-parachain download and setup instructions     

    zombienet/download_polkadot.sh

  • Added download command for polkadot-parachain.
  • Updated environment variable setup instructions.
  • +5/-2     
    Tests
    3 files
    mod.rs
    Add tests for Zombinet sovereign accounts                               

    xcm-simulator/src/tests/mod.rs

    • Added assertions for zombinet_para_id sovereign accounts.
    +10/-0   
    test-teleport-laos.ts
    Implement E2E test for asset teleportation between LAOS and Asset Hub

    e2e-tests/tests/test-teleport-laos.ts

  • Added end-to-end test for teleporting assets between LAOS and Asset
    Hub.
  • Implemented steps for creating and minting foreign assets.
  • Added liquidity pool creation and teleportation tests.
  • +472/-0 
    test-staking.ts
    Update staking tests to use LAOS network context                 

    e2e-tests/tests/test-staking.ts

    • Updated to use context.networks.laos for staking tests.
    +2/-2     
    Configuration changes
    3 files
    config.ts
    Update configuration for LAOS and Asset Hub nodes               

    e2e-tests/tests/config.ts

  • Updated node URLs and parachain IDs for LAOS and Asset Hub.
  • Added CHECKING_ACCOUNT constant.
  • +6/-1     
    native.toml
    Update Zombienet configuration for Asset Hub and logging 

    zombienet/native.toml

  • Updated node names and added logging arguments.
  • Added configuration for Asset Hub parachain.
  • +37/-9   
    e2e.yml
    Update GitHub Actions for Asset Hub command setup               

    .github/workflows/e2e.yml

    • Added environment variable for ZOMBIENET_ASSETHUB_COMMAND.
    +1/-0     
    Dependencies
    1 files
    package.json
    Update dependencies and test configuration                             

    e2e-tests/package.json

  • Updated dependencies for Polkadot API and utilities.
  • Increased test timeout and added --exit flag.
  • +8/-4     
    Formatting
    1 files
    metadata15.golden
    Update metadata file formatting                                                   

    runtime/laos/src/tests/metadata15.golden

    • Minor formatting change at the end of the file.
    +1/-1     
    Additional files (token-limit)
    1 files
    package-lock.json
    ...                                                                                                           

    e2e-tests/package-lock.json

    ...

    +3067/-466

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    luispdm
    luispdm previously approved these changes Nov 5, 2024
    tsenovilla
    tsenovilla previously approved these changes Nov 5, 2024
    Copy link
    Contributor

    @luispdm luispdm left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved but let's wait for @magecnion 's review before actually merging

    Copy link
    Contributor

    @luispdm luispdm left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Requesting changes to fix conflicts (to avoid accidental merge)

    luispdm
    luispdm previously approved these changes Nov 13, 2024
    tsenovilla
    tsenovilla previously approved these changes Nov 13, 2024
    @tsenovilla tsenovilla dismissed stale reviews from luispdm and themself via f531255 November 13, 2024 11:53
    @magecnion magecnion merged commit 4076f10 into main Nov 13, 2024
    30 checks passed
    @magecnion magecnion deleted the feature/zombienet-test-asset-hub branch November 13, 2024 15:38
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    XCM allows for Sending and Receiving MERC Tokens to/from AssetHub in Zombienet
    4 participants