Published albums must have at least one track #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publishing an album with no tracks doesn't make much sense and causes exceptions like this one [1], because the album has no preview to point the audio element at. [1]: https://app.rollbar.com/a/gofreerange/fix/item/jam/49 Fixes #148.
There was still only this one when I deployed, so I've unpublished the album and emailed the artist. I noticed that they have added a future release date to the album title, so I wonder if the album was acting as a placeholder for a forthcoming album. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing an album with no tracks doesn't make much sense and causes exceptions like this one, because the album has no preview to point the audio element at.
We'll also need to unpublish any published albums that have no tracks. These can be found by running
Album.published.select { |a| a.tracks.count == 0 }.map(&:slug). Currently there is only this one. I plan to email any affected artists to explain why we've unpublished their album. I contemplated doing the unpublishing in a migration, but since there's only one at the moment, I plan to do it in a Rails console in production.Fixes #148.