Suppress sending emails to deactivated email addresses #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were previously passing by accident, because we were never actually attempting to deliver the mail.
floehopper
deleted the
suppress-sending-emails-to-deactivated-email-addresses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key commits are:
These change should mean we avoid seeing too many exceptions like this one.
Ideally I think it might be worth normalizing the database structure so we only store email addresses and the suppressed timestamp in one table, but that's a job for another day.
I've also fixed a bunch of mailer tests so that they're actually testing what they were meant to be testing.
Fixes #142.