Set Sidekiq retries to 3 even for ActionMailer::MailDeliveryJob #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ActionMailer::MailDeliveryJob` inherits from `ActiveJob::Base` [1]; not from `ApplicationJob`. I suspect that's why the retry option in `ApplicationJob` didn't seem to be having any effect on jobs created by sending an email. It's hard to get a definitive answer, but I'm fairly confident setting the `retry` option on `Sidekiq.default_job_options` should apply globally to all jobs sent to Sidekiq, i.e. including `ActionMailer::MailDeliveryJob`. Fixes #143 (hopefully!🤞) [1]: https://github.com/rails/rails/blob/23938052acd773fa24068debe56cd892cbf8d868/actionmailer/lib/action_mailer/mail_delivery_job.rb#L13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionMailer::MailDeliveryJobinherits fromActiveJob::Base; not fromApplicationJob. I suspect that's why theretryoption inApplicationJobdidn't seem to be having any effect on jobs created by sending an email.It's hard to get a definitive answer, but I'm fairly confident setting the
retryoption onSidekiq.default_job_optionsshould apply globally to all jobs sent to Sidekiq, i.e. includingActionMailer::MailDeliveryJob.Fixes #143 (hopefully!🤞)