Display filename of existing profile picture in artist form #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even if this doesn't do everything that was envisaged in #60, I still think it's an improvement and makes the artist form more consistent with the album form, so I'm going to merge it. |
Unlike in this commit [1], I've used the built-in `ActionView::Helpers::FormBuilder#label` method rather than the customized `TailwindFormBuilder#labels` method that I used for the file fields in the album form. That's because at the moment there aren't any validation rules on `Artist#profile_picture`, so we don't (yet) need to be able to display validation errors withinin the label. c.f. this commit [1]. See #60. [1]: 3aaec28
floehopper
force-pushed
the
display-filename-of-existing-artist-profile-picture
branch
from
d4c0e08
to
87ad760
Compare
floehopper
deleted the
display-filename-of-existing-artist-profile-picture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike in this commit, I've used the built-in
ActionView::Helpers::FormBuilder#labelmethod rather than the customizedTailwindFormBuilder#labelsmethod that I used for the file fields in the album form. That's because at the moment there aren't any validation rules onArtist#profile_picture, so we don't (yet) need to be able to display validation errors withinin the label.See #60.
New artist page
Edit artist page