Upgrade some dependencies #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR @joggee-fr It looks like https://github.com/freeotp/freeotp-android/actions/runs/9714722536/job/26814449772?pr=403 |
Done by the AGP Upgrade Assistant in Android Studio.
As recommended by the AGP Upgrade assistant in Android Studio.
Instead of also using org.jetbrains.annotations.
Added in commit 64ea85a but does not seem to be used in project. However, it was hiding an issue with Kotlin functions import from io.fotoapparat. Directly add Kotlin stdlib as dependency to fix it. Check out RedApparat/Fotoapparat#370 for details.
FreeOTP does not use local JAR as dependencies. It just seems an old directive from Android Studio default template which has been removed now. Check https://issuetracker.google.com/issues/145977222.
Minor release and changes from 2.1.3.
|
Thanks @justin-stephenson. I will check this issue but I need to understand a bit more how these Mockito tests run first. |
Upgrade Mockito from 2.23.0 to 2.24.0 to avoid the following issue: org.mockito.exceptions.base.MockitoException: Mockito cannot mock this class: class android.content.Context. Underlying exception : java.lang.IllegalArgumentException: On Android P, a class injection can only be applied to BaseDexClassLoader: net.bytebuddy.dynamic.loading.MultipleParentClassLoader@23f7dce Looking at Mockito 2.x release notes: https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md - Previous issue may have been fixed in later 2.23.18 published on now unavailable Mockito Bintray repository. Consequently, move to 2.24.0 release available on Maven Central. - It seems that from 2.23.13 and androidx.test support added, tests are now launched in a dedicated instrumentation thread that does not prepare an Android Looper. But as Adapter class will instatiate an Android Handler, even if not needed for the tests, the following error is encountered: java.lang.RuntimeException: Can't create handler inside thread Thread[Instr: androidx.test.runner.AndroidJUnitRunner,5,main] that has not called Looper.prepare() Consequently, force the Looper to be prepared once before tests.
joggee-fr
force-pushed
the
jg/dependencies
branch
from
eae98c5
to
07bff84
Compare
|
@justin-stephenson, my last commit should fix the issue observed with token adapter tests. |
|
Thank you very much @joggee-fr PR looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small (first) step to update the dependencies of the project.