Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets #181

Closed
wants to merge 12 commits into from
Closed

Widgets #181

wants to merge 12 commits into from

Conversation

meme
Copy link

@meme meme commented Feb 15, 2018

Continuation off of #100 (due to inactivity)

@meme
Copy link
Author

meme commented Feb 15, 2018

Also: I was not sure what the reviewer meant in #100 (comment)

@olivierperez
Copy link

olivierperez commented Feb 27, 2018

Did you looked at the comment I made on the #100 ?

For the question about the review, my point is: Using "Linear+ImageView+TextView" to display an image on the left side of a TextView is like directly using the attribute drawableLeft of the TextView.

@meme
Copy link
Author

meme commented Feb 27, 2018

Awesome! I'll look into this, thanks. Just curious: are the tests broken or something? I'll try to run the tests locally and see if I get the same NullPointerExceptions that Travis seems to be getting.

@olivierperez
Copy link

Can you also remove the .idea folder of the PR, it should not be committed.

You may add it to .gitignore.

@meme
Copy link
Author

meme commented Feb 28, 2018

Alright, so, it seems that the unit tests are failing for me locally as well, I feel like we might want to handle that in a separate pull request or possibly master? I could just pull them back in here.

@meme
Copy link
Author

meme commented Feb 28, 2018

As well, I'll look into the drawableLeft as soon as I can, I'll try to find the time.

@meme meme closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants