Update Fotoapparat dependency to 2.2.0 #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirayudesai
commented
Feb 7, 2018
| @@ -11,6 +11,7 @@ buildscript { | |||
|
|
|||
| allprojects { | |||
| repositories { | |||
| google() | |||
There was a problem hiding this comment.
Unrelated, but I couldn't compile without this, it tried to include "com.android.support" by default and couldn't find it.
chirayudesai
commented
Feb 7, 2018
| @@ -136,11 +137,10 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| fotoapparat = Fotoapparat | |||
| .with(this) | |||
| .into(cameraView) | |||
| .previewScaleType(ScaleType.CENTER_CROP) | |||
| .photoSize(biggestSize()) | |||
There was a problem hiding this comment.
Need to see what this can be, we have photoResolution and previewResolution available separately now, and values taken is highestResolution
|
I used this code while working on our Attestation app 1, thought I might as well push the changes here. One thing I noticed (before and after the update) is that preview is laggy on debug app builds, for more details see: RedApparat/Fotoapparat#205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needed some code changes as Fotoapparat was re-written in Kotlin