Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation for the App and Play Store description (in /doc). #174

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

futal
Copy link

@futal futal commented Jan 15, 2018

I am planning to expand /doc with an actual user manual. I did not know how 2FA works when I installed FreeOTP and I was expecting to find some user manual when I first visited the repo.

Copy link
Collaborator

@dvanbalen dvanbalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with Google Translate

Copy link
Collaborator

@dvanbalen dvanbalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation fails unless apostrophes are escaped

<string name="about_version">FreeOTP version %1$s (%2$d)</string>
<string name="about_copyright">© 2013 - Red Hat, Inc., et al.</string>
<string name="about_license">FreeOTP est publié sous licence %1$s.</string>
<string name="about_website">Pour plus d'informations, voir notre %s.</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apostrophes need to be escaped

Suggested change
<string name="about_website">Pour plus d'informations, voir notre %s.</string>
<string name="about_website">Pour plus d\'informations, voir notre %s.</string>

<string name="link_website"><a href="https://freeotp.github.io">site web</a></string>
<string name="link_apache2"><a href="https://www.apache.org/licenses/LICENSE-2.0.html">Apache 2.0</a></string>

<string name="error_camera_open">Erreur lors de l'accès à l'appareil photo !</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="error_camera_open">Erreur lors de l'accès à l'appareil photo !</string>
<string name="error_camera_open">Erreur lors de l\'accès à l\'appareil photo !</string>

<string name="link_apache2"><a href="https://www.apache.org/licenses/LICENSE-2.0.html">Apache 2.0</a></string>

<string name="error_camera_open">Erreur lors de l'accès à l'appareil photo !</string>
<string name="error_permission_camera_open">Pas autorisé à accéder à l'appareil photo</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="error_permission_camera_open">Pas autorisé à accéder à l'appareil photo</string>
<string name="error_permission_camera_open">Pas autorisé à accéder à l\'appareil photo</string>


<string name="error_camera_open">Erreur lors de l'accès à l'appareil photo !</string>
<string name="error_permission_camera_open">Pas autorisé à accéder à l'appareil photo</string>
<string name="error_image_open">Erreur lors de l'ouverture de l'image !</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="error_image_open">Erreur lors de l'ouverture de l'image !</string>
<string name="error_image_open">Erreur lors de l\'ouverture de l\'image !</string>

@joggee-fr joggee-fr mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants