feat(pacer.email): improve bankruptcy short description parsing #1276

grossir · 2024-12-17T05:15:56Z

Solves #912, Solves #914

simplify parsing by getting rid of cases by court groups
support multi docket NEF parsing: add examples for deb, ctb, mdb, ndb, nhb, paeb, txnb
support flsb
correct wrong parsing for vaeb and mdb after double checking on PACER
updated paeb_1 example file where creation of example file had broken parsing

Solves #912, Solves #914 - simplify parsing by getting rid of cases by court groups - support multi docket NEF parsing: add examples for deb, ctb, mdb, ndb, nhb, paeb, txnb - support flsb - correct wrong parsing for vaeb and mdb after double checking on PACER - updated paeb_1 example file where creation of example file had broken parsing

mlissner

Wow, you really simplified the code while adding a bunch more test cases. Love it.

How much have you checked vs. the pacer history reports to make sure that your output is correct?

grossir

I left a screenshot of the "History/Documents" report on most JSON files to explain the changes. I noticed I need to improve the parsing of a couple of them

grossir · 2024-12-17T21:58:56Z

tests/examples/pacer/nef/s3/dcb_2.json

@@ -16,7 +16,7 @@
          "pacer_doc_id": null,
          "pacer_magic_num": null,
          "pacer_seq_no": null,
-          "short_description": "Hearing Held"
+          "short_description": "Hearing Held (BK)"


Document number 56 has short description "Hearing Held (BK)"

grossir · 2024-12-17T22:08:22Z

juriscraper/pacer/email.py

+
+        # Deletes:
+        # - extra docket number 'components', such as `federal_dn_judge_initials_assigned`
+        # - Chapter component


On deleting "Chapter", see nhb1 example
The email's subject is
Subject:21-10245-BAH Chapter 13 Mykle Lepene Affidavit of Compliance with Discharge Requirements
if we didn't delete the "Chapter" the short_description would be
"Chapter 13 Affidavit of Compliance with Discharge Requirements"
but it's different on pacer

grossir · 2024-12-17T22:09:29Z

tests/examples/pacer/nef/s3/paeb_2.json

@@ -16,7 +16,7 @@
          "pacer_doc_id": null,
          "pacer_magic_num": null,
          "pacer_seq_no": null,
-          "short_description": "CHAP - Hearing Continued"
+          "short_description": "CHAP - Hearing Continued (Bk Other)"


On keeping "CHAP" and "(Bk Other)"

grossir · 2024-12-17T22:10:14Z

tests/examples/pacer/nef/s3/vaeb_1.json

@@ -16,7 +16,7 @@
          "pacer_doc_id": "188040985133",
          "pacer_magic_num": "49963627",
          "pacer_seq_no": "101",
-          "short_description": "Notice of Dismissal"
+          "short_description": "Notice of Dismissal - CerDocTyp"


On keeping "CerDocTyp"

grossir · 2024-12-17T22:12:15Z

tests/examples/pacer/nef/s3/tnmb_1.json

@@ -16,7 +16,7 @@
          "pacer_doc_id": null,
          "pacer_magic_num": null,
          "pacer_seq_no": null,
-          "short_description": "Docket Order - Continue Hearing (Auto) Ch 13"
+          "short_description": "Docket Order - Continue Hearing (Auto)"


On deleting "Ch 13"

grossir · 2024-12-17T22:14:50Z

tests/examples/pacer/nef/s3/mdb_multi_2.json

+          "pacer_doc_id": null,
+          "pacer_magic_num": null,
+          "pacer_seq_no": null,
+          "short_description": "Close Adversary Case"


Subject in the email is
"Multiple Cases "Close Adversary Case" - AP -"

Should be reduced to "Close Adversary Case". It doesn't follow the usual clean up process, that's why I am using the early return

grossir · 2024-12-17T22:22:07Z

tests/examples/pacer/nef/s3/flsb_1.json

+          "pacer_doc_id": "050057572723",
+          "pacer_magic_num": "58443666",
+          "pacer_seq_no": "384",
+          "short_description": "UST Form 11"


This one should be "UST Form 11-MOR"

grossir · 2024-12-17T22:25:25Z

tests/examples/pacer/nef/s3/mdb_2.json

@@ -16,7 +16,7 @@
          "pacer_doc_id": "092051714783",
          "pacer_magic_num": "11582823",
          "pacer_seq_no": "409",
-          "short_description": "Order on Motion To Quash"
+          "short_description": "Order on Motion To Quash - CH"


This one shouldn't have the lagging " - CH"

grossir · 2024-12-17T22:26:15Z

tests/examples/pacer/nef/s3/mdb_multi_1.json

+          "pacer_doc_id": null,
+          "pacer_magic_num": null,
+          "pacer_seq_no": null,
+          "short_description": "Close Adversary Case"


This one is OK

grossir · 2024-12-17T22:27:44Z

tests/examples/pacer/nef/s3/paeb_1.json

@@ -4,7 +4,7 @@
  "court_id": "paeb",
  "dockets": [
    {
-      "case_name": "Br Cun",
+      "case_name": "Brittany Cunningham",


Editing the example source had messed up the parsing of this case

mlissner · 2024-12-18T18:00:09Z

Great. Thanks Gianfranco. Assigning to Alberto for review.

grossir · 2024-12-18T18:01:40Z

I am missing one more commit; I have been checking the old example files too and doing some minor updates

Keep "Chapter ..." string in paeb and pamb courts

for more information, see https://pre-commit.ci

grossir · 2024-12-18T20:12:38Z

tests/examples/pacer/nef/s3/pamb_4.json

+          "pacer_doc_id": "154018316665",
+          "pacer_magic_num": "88545762",
+          "pacer_seq_no": "31",
+          "short_description": "BNC Certificate of Notice (341 Meeting Notice (Chapter 13))"


We keep the "Chapter ..." string

Email subject:
Subject:Ch-13 1:24-bk-00941-HWV -Charlene R. House BNC Certificate of Notice (341 Meeting Notice (Chapter 13))

Document history report:

grossir · 2024-12-18T20:14:44Z

tests/examples/pacer/nef/s3/paeb_3.json

+          "pacer_doc_id": "152032523670",
+          "pacer_magic_num": "29282863",
+          "pacer_seq_no": "78",
+          "short_description": "Chapter 13 Plan"


We keep the "Chapter..." string

Email subject:
Subject:Ch-13 23-13878-pmm Chapter 13 Plan - Kervince Markenzy

History report

grossir · 2024-12-18T20:17:13Z

@albertisfu this now ready for review

albertisfu

Thanks @grossir I reviewed the refactor applied, and it looks good to me.
I just left a comment and a couple of concerns after finding some examples where the conditions for deciding when to keep or remove some suffixes and Chapter could be problematic.

juriscraper/pacer/email.py

albertisfu · 2024-12-24T01:41:28Z

juriscraper/pacer/email.py

+        component_regex = r"((?!-MOR)(\-[A-Z]{2,}))|(\-[a-z]{2,})|(NEF:? )"
+        if self.court_id in ["paeb", "pamb"]:
+            # keeps the "Chapter ..." description on the short description
+            chapter_regex = r"(C[Hh][- ]?(13|7|9|11))|(C[hH][\s-]*$)"


Without looking too much I was able to find a couple of examples where the removal of Chapter... is not compatible.

For instance this one:
cacb_2.txt

You can see that in the Docket history report, many entries retain "Chapter" in their short descriptions.

Another example comes from pawb:

It seems difficult to determine when Chapter... should be removed. I’m also not sure if it's a consistent behavior across courts. If it should sometimes be removed and sometimes not in the same court that's a problem unless we can found a different pattern to decide. However, if it is consistent, we should look for more courts where it should be retained and add them to the condition.

I added an example with "Chapter..." or "Ch..." for each court; except for nyeb, for which I couldn't find any

- Add `casb` examples - Add examples with a "Chapter.." string for all courts except nyeb, for which I couldn't find any - Solved bugs pointed out in code review - Now using saved raw case numbers to clean up the subject. This simplifies the process

grossir · 2025-01-08T15:50:20Z

Hi @albertisfu thanks for the review; I think this is ready for review again; I have simplified the code by using the "raw" docket number, befor it is separated into components

grossir · 2025-01-08T15:57:37Z

tests/examples/pacer/nef/s3/ianb_2.json

+          "pacer_doc_id": "07404406548",
+          "pacer_magic_num": "85473386",
+          "pacer_seq_no": "4579",
+          "short_description": "Order Confirming Chapter 11 Plan"


grossir · 2025-01-08T15:58:54Z

tests/examples/pacer/nef/s3/okeb_3.json

+          "pacer_doc_id": "14404609723",
+          "pacer_magic_num": "39816587",
+          "pacer_seq_no": "190",
+          "short_description": "Chapter 11 Monthly Operating Report UST Form 11-MOR"


grossir · 2025-01-08T15:58:58Z

tests/examples/pacer/nef/s3/nhb_2.json

+          "pacer_doc_id": "11606636788",
+          "pacer_magic_num": "97314543",
+          "pacer_seq_no": "304",
+          "short_description": "Chapter 13 Trustee's Interim Report Upon Completion of Plan Payments (batch)"


grossir · 2025-01-08T16:00:00Z

tests/examples/pacer/nef/s3/casb_2.json

+          "pacer_doc_id": "036021419934",
+          "pacer_magic_num": "29072456",
+          "pacer_seq_no": "2",
+          "short_description": "Chapter 7 Voluntary Petition"


albertisfu

Thanks, @grossir. The changes look pretty good. I just left a couple of small comments, and I think we'll be ready to merge this.

juriscraper/pacer/email.py

albertisfu · 2025-01-08T22:11:14Z

juriscraper/pacer/email.py

+        # Courts like `nhb` do not use the "Ch \d{1,2}" abbreviation
+        # and we must delete the "Chapter..." string; but only once
+        # See nhb_2 for an example with 2 "Chapter..." strings
+        if self.court_id in ["nhb"]:


Would it be a good idea to log an error message in Sentry (except for nhb) when we find an email subject with more than one 'Chapter...' string? This way, we can detect if there are other courts that need to be added to this list of exceptions?

I have added a logger.error call for this case; and another for when we encounter an email from a court for which we have no examples

tests/examples/pacer/nef/s3/cacb_3.json

tests/examples/pacer/nef/s3/cob.json

tests/examples/pacer/nef/s3/paeb_3.json

- add logger.error calls for courts without examples; and for unexpected usage of "Chapter.." strings - restore overwritten test cases - add a test case for nceb - handle plain/text as seen in cob example

grossir · 2025-01-09T01:36:40Z

@albertisfu thanks for the review; I have addressed your comments, please check again when you have time

albertisfu · 2025-01-10T02:30:19Z

Thanks, @grossir. With the new loggers, we can confirm the parsing once we get new examples.

@mlissner this seems ready to merge!

mlissner · 2025-01-10T04:30:11Z

Whew! Thanks guys!

grossir force-pushed the recap_email_bankruptcy_short_description branch from 1369764 to ecfc625 Compare December 17, 2024 05:23

grossir requested a review from mlissner December 17, 2024 15:02

grossir assigned mlissner Dec 17, 2024

grossir mentioned this pull request Dec 17, 2024

feat(pacer.email): multi docket NEF bankruptcy short description #1013

Closed

mlissner reviewed Dec 17, 2024

View reviewed changes

grossir commented Dec 17, 2024

View reviewed changes

fix(recap.email): refine bankruptcy short_description parsing

94b2d60

mlissner assigned albertisfu and unassigned mlissner Dec 18, 2024

mlissner requested a review from albertisfu December 18, 2024 17:59

grossir and others added 2 commits December 18, 2024 15:08

fix(pacer.email): improve bankruptcy short description

1e0dbe9

Keep "Chapter ..." string in paeb and pamb courts

[pre-commit.ci] auto fixes from pre-commit.com hooks

71281ae

for more information, see https://pre-commit.ci

grossir commented Dec 18, 2024

View reviewed changes

albertisfu reviewed Dec 24, 2024

View reviewed changes

albertisfu assigned grossir and unassigned albertisfu Dec 24, 2024

wip: add casb

57476e1

grossir mentioned this pull request Jan 7, 2025

DocketEntry with multiple RecapDocuments overwrites single RecapDocument instead of creating many freelawproject/courtlistener#4895

Open

grossir added 2 commits January 8, 2025 00:39

Merge branch 'main' into recap_email_bankruptcy_short_description

7fdc3d0

grossir assigned albertisfu and unassigned grossir Jan 8, 2025

grossir requested a review from albertisfu January 8, 2025 15:50

grossir commented Jan 8, 2025

View reviewed changes

albertisfu reviewed Jan 8, 2025

View reviewed changes

grossir added 3 commits January 8, 2025 20:22

fix(pacer.email): add logger.error calls for unexpected cases

f2d2c3b

- add logger.error calls for courts without examples; and for unexpected usage of "Chapter.." strings - restore overwritten test cases - add a test case for nceb - handle plain/text as seen in cob example

Merge branch 'main' into recap_email_bankruptcy_short_description

f5e6bb3

refactor(pacer.email): tweak logger.error messages

93c4d4b

mlissner merged commit 5981261 into main Jan 10, 2025
12 checks passed

mlissner deleted the recap_email_bankruptcy_short_description branch January 10, 2025 04:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pacer.email): improve bankruptcy short description parsing #1276

feat(pacer.email): improve bankruptcy short description parsing #1276

grossir commented Dec 17, 2024

mlissner left a comment

grossir left a comment

grossir Dec 17, 2024

grossir Dec 17, 2024

grossir Dec 17, 2024

grossir Dec 17, 2024

grossir Dec 17, 2024

grossir Dec 17, 2024

grossir Dec 17, 2024

grossir Dec 17, 2024

grossir Dec 17, 2024

grossir Dec 17, 2024

mlissner commented Dec 18, 2024

grossir commented Dec 18, 2024

grossir Dec 18, 2024

grossir Dec 18, 2024

grossir commented Dec 18, 2024

albertisfu left a comment

albertisfu Dec 24, 2024

grossir Jan 8, 2025

grossir commented Jan 8, 2025

grossir Jan 8, 2025

grossir Jan 8, 2025

grossir Jan 8, 2025

grossir Jan 8, 2025

albertisfu left a comment

albertisfu Jan 8, 2025

grossir Jan 9, 2025

grossir commented Jan 9, 2025

albertisfu commented Jan 10, 2025

mlissner commented Jan 10, 2025

feat(pacer.email): improve bankruptcy short description parsing #1276

feat(pacer.email): improve bankruptcy short description parsing #1276

Conversation

grossir commented Dec 17, 2024

mlissner left a comment

Choose a reason for hiding this comment

grossir left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlissner commented Dec 18, 2024

grossir commented Dec 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grossir commented Dec 18, 2024

albertisfu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grossir commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

albertisfu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grossir commented Jan 9, 2025

albertisfu commented Jan 10, 2025

mlissner commented Jan 10, 2025