Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pa): collect neutral citations and regional citations; also paginate results #1255

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Nov 21, 2024

Helps solve
#1251
#1252
#1253

Fixes #1253

Some opinions were lost due to inability to paginate, specially for pasuperct
Solves #1252

Have only seen them for pasuperct, where I added a test case with citations.
@grossir grossir requested a review from flooie November 21, 2024 17:55
@flooie flooie self-assigned this Dec 16, 2024
@flooie
Copy link
Contributor

flooie commented Jan 7, 2025

Can you resolve the conflicts please @grossir

@grossir
Copy link
Contributor Author

grossir commented Jan 7, 2025

I solved the merge conflicts, but it seems to be failing due to the absca tests

@flooie
Copy link
Contributor

flooie commented Jan 7, 2025

Check the PR I just did in NH -that adjusts that scraper for testing purposes. if you merge that a then merge them that should resolve it.

@grossir
Copy link
Contributor Author

grossir commented Jan 7, 2025

@flooie no failing tests now

@grossir grossir removed their assignment Jan 7, 2025
@flooie flooie merged commit ea57762 into main Jan 8, 2025
11 checks passed
@flooie flooie deleted the fix_pa branch January 8, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants