Context Menu Builder still referred to draft/ location #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The context menu still refered to context-menu include with a draft and our test suite didn't exercise it, so the code doens't build against 1.2.0 Fix both the include and add a test
abique
approved these changes
Jan 22, 2024
|
LGTM |
|
Great. I merged to main; we should probably reset next soon enough once we do the branching and tagging also. But lemme get surge and CJE going. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context menu still refered to context-menu include with
a draft and our test suite didn't exercise it, so the code
doens't build against 1.2.0
Fix both the include and add a test