-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CMS Starter example #134
base: main
Are you sure you want to change the base?
Conversation
ce26e37
to
fc608ad
Compare
fc608ad
to
36e36fc
Compare
36e36fc
to
354b9f5
Compare
Signed-off-by: Cédric Boirard <[email protected]>
Signed-off-by: Cédric Boirard <[email protected]>
64eda3c
to
405e0df
Compare
4104a2f
to
ba7fd80
Compare
ba7fd80
to
d5d0288
Compare
Signed-off-by: Cédric Boirard <[email protected]>
d5d0288
to
80d249f
Compare
- Chore Signed-off-by: Cédric Boirard <[email protected]>
Lets call the actual folder "cms" instead of "cms-starter" since its already in a folder called "examples" |
Trying to actually swap in my own cms source (bluesky) its not the most clear process still. In theory it should be pretty simple, to get the data this is enough, but then I run into complexity of not sure how to set things up import { AtpAgent } from "@atproto/api"
const agent = new AtpAgent({
service: "https://public.api.bsky.app",
})
const profile = await agent.getProfile({ actor: "framer.com" })
const { data } = await agent.getAuthorFeed({
actor: profile.data.did,
filter: "posts_and_author_threads",
limit: 30,
})
|
starters/cms/src/data.ts
Outdated
const dataSource: { | ||
id: string | ||
fields: { | ||
name: string | ||
type: string | ||
}[] | ||
items: Record<string, unknown>[] | ||
} = await fetch(`/datasources/${dataSourceId}.json`, { signal: abortSignal }).then(response => response.json()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: lets split this on a few lines, its a bit weird to deconstruct directly from the fetch like that on the same line I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think keeping the DataSource type separate is easier to read rather than inline like this
Yes, we can do that but I think it's better if we re-use the types we already defined right? |
Signed-off-by: Cédric Boirard <[email protected]> rm motion Signed-off-by: Cédric Boirard <[email protected]>
Signed-off-by: Cédric Boirard <[email protected]>
Signed-off-by: Cédric Boirard <[email protected]>
Signed-off-by: Cédric Boirard <[email protected]>
Signed-off-by: Cédric Boirard <[email protected]>
Signed-off-by: Cédric Boirard <[email protected]>
Signed-off-by: Cédric Boirard <[email protected]>
3293814
to
ed6c44d
Compare
Signed-off-by: Cédric Boirard <[email protected]>
Signed-off-by: Cédric Boirard <[email protected]>
Description
This pull request introduces a new CMS starter example, including updates to various configuration files, data sources, and UI components. The changes aim to set up a basic CMS plugin for Framer, providing a template for further development.
QA
examples/cms
directory.Additional Checks