Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fix the Navigation focus trap #738

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ui): fix the Navigation focus trap #738

wants to merge 3 commits into from

Conversation

AliKdhim87
Copy link
Contributor

@AliKdhim87 AliKdhim87 commented May 22, 2024 •
edited
Loading

Issue link

  • Focus trap Issue

    • Before:

      Screen.Recording.2024-09-12.at.17.21.55.mov

    • After:

      Screen.Recording.2024-09-12.at.17.24.57.mov

  • Lock Body issue:

    • Before:
    Screen.Recording.2024-09-12.at.17.28.00.mov
    • After:
    Screen.Recording.2024-09-12.at.17.31.53.mov

@AliKdhim87 AliKdhim87 requested a review from bddjong May 22, 2024 08:46
@AliKdhim87 AliKdhim87 linked an issue May 22, 2024 that may be closed by this pull request
Tabbing in Hamburger menu gaat buiten de grenzen van zichzelf #683
Open
@AliKdhim87 AliKdhim87 requested a review from Robbert May 27, 2024 13:56
Robbert
Robbert requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@Robbert Robbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zou je hier tests voor willen schrijven?

@AliKdhim87 AliKdhim87 force-pushed the fix-nav-focus-trap-issue branch from 7d63931 to 34ac872 Compare September 12, 2024 15:14
@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cms-frameless-io ❌ Failed (Inspect) Sep 13, 2024 7:42am
tiptap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 7:42am

@AliKdhim87 AliKdhim87 requested a review from Robbert September 12, 2024 15:17
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...src/components/Navigation/NavigationLink/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/Navigation/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/hooks/index.tsx 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@AliKdhim87
fix(ui): fix the Navigation focus trap
2d40a78
@AliKdhim87
fix: resolve body lock issue
29261f6 
- The body becomes locked when closing the drawer by pressing "Esc" or clicking outside.
- Refactor the body lock logic to use the useLockBody hook.
@AliKdhim87
test: add unit test to Navigation components
6a24034
@AliKdhim87 AliKdhim87 force-pushed the fix-nav-focus-trap-issue branch from 34ac872 to 6a24034 Compare September 13, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bddjong bddjong Awaiting requested review from bddjong

@Robbert Robbert Awaiting requested review from Robbert

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabbing in Hamburger menu gaat buiten de grenzen van zichzelf
2 participants
@AliKdhim87 @Robbert