-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for python=312 #846
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
@lorenzocerrone with poetry you should remember to update the actual dependency version, e.g. with |
I see several I suggest we take one of these options:
|
Last comment: would it make sense to also address #821 here? |
Looks generally good to me. Unlocking torch can lead to issues in some deployments, but we anyway pin torch on UZH installations through "Add pinned packages" already, so we have a mechanism for that. Whether we should pin pandas or address the issues: Some may go away with ngio. The cellvoyager/metadata.py related ones would probably stay. So we should at least address those here eventually |
|
No, this is not enough:
|
I don't know precisely the reason, but poetry is not automatically updating numpy to v2 in the lock file. This is most likely due to some funny pin on astropy (astropy/astropy#15234), where they stopped supporting numpy v2 after some version. If you ran tests locally, that's good. Moreover, the |
torch
is required forpython=3.12
pandas
makes thefractal-tasks-core
installation (and CI) much faster.Checklist before merging
CHANGELOG.md