Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APX branch in manifest_external_packages.yml #806

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jul 24, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

@tcompa
Copy link
Collaborator Author

tcompa commented Jul 24, 2024

This PR is meant to make the APX manifest-creation github action pass, but we still need @adrtsc to update the fractal-tasks-core dependency in APX (since it still depends on the pydantic-v2-second-attempt branch which doesn't exist any more).

Note that the other external-packages GitHub actions will keep failing until those packages update their manifest to a pydantic_v2 one.

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@tcompa
Copy link
Collaborator Author

tcompa commented Jul 24, 2024

This PR is meant to make the APX manifest-creation github action pass, but we still need @adrtsc to update the fractal-tasks-core dependency in APX (since it still depends on the pydantic-v2-second-attempt branch which doesn't exist any more).

Now working.

@tcompa tcompa merged commit 390e613 into main Jul 24, 2024
17 of 19 checks passed
@tcompa tcompa deleted the tcompa-patch-1 branch July 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant