Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cast storage): respect --json for layout #9332

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(cast storage): respect --json for layout #9332

wants to merge 6 commits into from
+62 −3

Commits on Nov 15, 2024

  1. feat(cast storage): allow ugly printing of layout 

    Prior to this change, `cast storage $ADDRESS --rpc-url $RPC_URL
--etherscan-api-key $ETHERSCAN_API_KEY` always provided a prettified
output.

This change adds a `--pretty` flag to `cast storage` which defaults to
`true` thus retaining backwards compatibility. Passing `--pretty=false`
to `cast storage` results in the json output of the storage layout being
produced instead.
    @MaxMustermann2
    MaxMustermann2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    abc2718 View commit details
    Browse the repository at this point in the history

  2. fix: remove default value from help text 

    The default value is accessible via `cast storage --help`
    @MaxMustermann2
    MaxMustermann2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    87312ea View commit details
    Browse the repository at this point in the history

  3. fix(cast storage): provide output json path

    @MaxMustermann2
    MaxMustermann2 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    89c895f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. test(cast): add storage_layout_simple_json test

    @MaxMustermann2
    MaxMustermann2 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    3e2f637 View commit details
    Browse the repository at this point in the history

  2. fix(cast storage): use --json flag to ugly print

    @MaxMustermann2
    MaxMustermann2 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    bcc1665 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/pretty-cast-storage

    @MaxMustermann2
    MaxMustermann2 authored Nov 16, 2024
    Configuration menu
    Copy the full SHA
    e08aa09 View commit details
    Browse the repository at this point in the history