fix(forge): temporary fix for ledger when using --hd-paths on forge script
#2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #2709
When passed
--hd-paths,ledgeractually instantiates 2Ledgerwallets. The defaultLedgerLive(0)and the one with user provided pathOther(hd_path. However,ledgercannot at the moment support more than two instantiations, since the first locks access to the device.Even if we didn't instantiate the default path, the same error behavior would happen if used with multiple
--hd-paths.Solution
Temporarily limit ledger to one instantiation only, while we extend support on
ethers-signersfor more. Otherwise,--hd-pathsis not usable at all.