Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appengine: Optimize app fetch check #370

Merged
merged 1 commit into from
Dec 6, 2024
Merged

appengine: Optimize app fetch check #370

merged 1 commit into from
Dec 6, 2024

Conversation

mike-sul
Copy link
Contributor

@mike-sul mike-sul commented Dec 6, 2024

If an app is successfully fetched and checked then mark it as "fetched" so the next time the app fetch check is called no need to invoke the full blown check performed by composectl.

If an app is successfully fetched and checked then mark it as "fetched"
so the next time the app fetch check is called no need to invoke the
full blown check performed by `composectl`.

Signed-off-by: Mike Sul <[email protected]>
@mike-sul mike-sul requested a review from detsch December 6, 2024 14:52
@mike-sul
Copy link
Contributor Author

mike-sul commented Dec 6, 2024

@detsch This simple approach should work because:

  1. If composectl pull is successful then it is guaranteed that an app is completely pulled and written/stored on a drive (it does checks internally and write through the tmp file technique).

  2. It does the full check after aklite's restart.

Copy link
Member

@detsch detsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-sul mike-sul merged commit b9c8513 into v94 Dec 6, 2024
5 checks passed
@mike-sul mike-sul deleted the optimize-fetch-check branch December 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants