Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Log execution of external commands during apps management #366

Merged
merged 1 commit into from
Dec 2, 2024
Merged

apps: Log execution of external commands during apps management #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/exec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include <boost/filesystem.hpp>
#include <boost/format.hpp>
#include <boost/process.hpp>
#include "logging/logging.h"

struct ExecError : std::runtime_error {
ExecError(const std::string& msg_prefix, const std::string& cmd, const std::string& err_msg, int exit_code)
Expand All @@ -23,6 +24,7 @@ static void exec(const std::string& cmd, const std::string& err_msg_prefix, Args
boost::asio::io_service io_service;

try {
LOG_DEBUG << "Running: `" << cmd << "`";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make it LOG_TRACE.

boost::process::child child_process(cmd, boost::process::std_err > err_output,
boost::process::on_exit = child_process_exit_code, io_service,
std::forward<Args>(args)...);
Expand All @@ -39,6 +41,7 @@ static void exec(const std::string& cmd, const std::string& err_msg_prefix, Args
}

const auto exit_code{child_process_exit_code.get()};
LOG_DEBUG << "Command exited with code " << exit_code;

if (exit_code != EXIT_SUCCESS) {
const auto err_msg{err_output.get()};
Expand Down