restorableappengine: Log app start #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print logs about an app start and successful completion. Logs printed to stdout by processes/utilities spawned by aklite are supressed since some of the utilities do odd/crazy stuff in the std output which makes aklite logs messy. As drawback, it makes successful execution some of utilities invisible, in particular `docker compose up` which is an important to see in the logs. This change prints logs before starting an app and just after successfull execution, so it becomes visible when an app was started. Note: if an app start failure occurs, then aklite will add the stderr output of the command to the aklite's logs. Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
log-app-start
branch
from
e1a35fe to
001afde
Compare
detsch
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print logs about an app start and successful completion.
Logs printed to stdout by processes/utilities spawned by aklite are supressed since some of the utilities do odd/crazy stuff in the std output which makes aklite logs messy. As drawback, it makes successful execution some of utilities invisible, in particular
docker compose upwhich is an important to see in the logs. This change prints logs before starting an app and just after successfull execution, so it becomes visible when an app was started. Note: if an app start failure occurs, then aklite will add the stderr output of the command to the aklite's logs.