Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composeappmanager: Stop apps only if rootfs update is expected #362

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mike-sul
Copy link
Contributor

Stop apps being updated only if ostree update and reboot is expected. Stopping apps in the case of an "app-only" update is not optimal, as it stops all app services/containers. In contrast, docker compose up can handle this more efficiently by restarting only those service containers whose images have been updated.

@mike-sul mike-sul requested a review from detsch November 15, 2024 11:32
Copy link
Member

@detsch detsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
E2e test failed because of a change introduced in PR #361. Once we merge it, tests will succeed.

Stop apps being updated only if ostree update and reboot is expected.
Stopping apps in the case of an "app-only" update is not optimal, as
it stops all app services/containers. In contrast, `docker compose up`
can handle this more efficiently by restarting only those service
containers whose images have been updated.

Signed-off-by: Mike Sul <[email protected]>
@mike-sul mike-sul force-pushed the stop-apps-only-if-ostree-update branch from 06952c2 to 08fec4d Compare November 20, 2024 09:28
@mike-sul mike-sul merged commit 4acec0a into master Nov 20, 2024
5 checks passed
@mike-sul mike-sul deleted the stop-apps-only-if-ostree-update branch November 20, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants