Revert composectl usage for checking whether app is installed
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 37c0249. The given functionality does not work if images hosted in docker.io are specified in a docker compose project file in a full format. For example, "docker.io/library/nginx:stable-alpine" or "docker.io/homeassistant/home-assistant:stable". The dockerd removes the "docker.io" or "docker.io/library" prefix when stores such images in its store and as result returns the image URIs in the shorten format in a response to "http://localhost/images/json?all=1" request. For example, "nginx@sha256:<hash>" or "homeassistant/home-assistant:<hash>". Therefore, it is not possible to map images listed in the compose project to images reported by dockerd unless the dockerd's URI shortening rules are taken in the "isAppInstalled" logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 37c0249.
The given functionality does not work if images hosted in docker.io are specified in a docker compose project file in a full format. For example, "docker.io/library/nginx:stable-alpine" or "docker.io/homeassistant/home-assistant:stable".
The dockerd removes the "docker.io" or "docker.io/library" prefix when stores such images in its store and as result returns the image URIs in the shorten format in a response to "http://localhost/images/json?all=1" request. For example, "nginx@sha256:" or "homeassistant/home-assistant@sha256:".
Therefore, it is not possible to map images listed in the compose project to images reported by dockerd unless the dockerd's URI shortening rules are taken in the "isAppInstalled" logic.