Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: Add offline support for check, pull, install and update commands #352

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

detsch
Copy link
Member

@detsch detsch commented Aug 16, 2024

No description provided.

@detsch detsch requested a review from mike-sul August 21, 2024 12:29
@detsch detsch force-pushed the detsch-allow-offline-mode branch from b2e3899 to 3d25ef7 Compare August 21, 2024 12:57
@detsch detsch marked this pull request as ready for review August 21, 2024 13:08
Copy link
Contributor

@mike-sul mike-sul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will do e2e testing tomorrow.

src/main.cc Show resolved Hide resolved
@detsch detsch force-pushed the detsch-allow-offline-mode branch 2 times, most recently from eeb1c12 to 53a9410 Compare August 26, 2024 19:05
@mike-sul
Copy link
Contributor

@detsch detsch force-pushed the detsch-allow-offline-mode branch from 53a9410 to 15672bb Compare August 27, 2024 17:32
@detsch
Copy link
Member Author

detsch commented Aug 27, 2024

@detsch We need to make clang tidy happy https://github.com/foundriesio/aktualizr-lite/actions/runs/10565675394/job/29270730335?pr=352

It was a legitimate error introduced on my last rebase. Fixed now.

@detsch detsch force-pushed the detsch-allow-offline-mode branch from 15672bb to ff6efdd Compare August 27, 2024 19:24
detsch added 2 commits August 27, 2024 16:54
Avoids having an invalid docker_client_ptr value when LocalUpdateSource
is instantiated as a local variable.

Signed-off-by: Andre Detsch <[email protected]>
@detsch detsch force-pushed the detsch-allow-offline-mode branch from ff6efdd to 455d2c0 Compare August 27, 2024 19:54
@detsch detsch merged commit 2b7f46f into master Aug 27, 2024
4 checks passed
@detsch detsch deleted the detsch-allow-offline-mode branch August 27, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants