Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add json output mode for 'check' and 'list' commands #351

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

detsch
Copy link
Member

@detsch detsch commented Aug 13, 2024

Implementation was straightforward, so I just made a first version while we get seek for some feedback

@detsch detsch requested a review from mike-sul August 13, 2024 17:30
@detsch detsch force-pushed the detsch-add-check-json branch 4 times, most recently from ee4d2be to 61ded57 Compare August 21, 2024 12:56
@detsch detsch marked this pull request as ready for review August 21, 2024 13:08
src/cli/cli.cc Outdated Show resolved Hide resolved
src/main.cc Show resolved Hide resolved
@detsch detsch force-pushed the detsch-add-check-json branch 2 times, most recently from 835ecb1 to b63abb7 Compare August 26, 2024 19:00
@detsch
Copy link
Member Author

detsch commented Aug 26, 2024

@mike-sul I've added two patches to better handle the log messages and --json option: Fixed the LOG_WARNING for non-root execution, and made loglevel "fatal" by default when using "--json 1".

@mike-sul
Copy link
Contributor

@mike-sul I've added two patches to better handle the log messages and --json option: Fixed the LOG_WARNING for non-root execution, and made loglevel "fatal" by default when using "--json 1".

It works better now, thanks.

detsch added 3 commits August 27, 2024 16:20
Move warning log message printing to after the log level is set, making
it respect the log level selected via command line.

Signed-off-by: Andre Detsch <[email protected]>
@detsch detsch force-pushed the detsch-add-check-json branch from b63abb7 to 8ff2cb0 Compare August 27, 2024 19:24
@detsch detsch merged commit 9c93495 into master Aug 27, 2024
4 checks passed
@detsch detsch deleted the detsch-add-check-json branch August 27, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants