api: Remove leftover callback invocation in CheckInCurrent #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
approved these changes
Jul 29, 2024
CheckInCurrent is not supposed to invoke callbacks nor generate events. Issue introduced in e6b6445 (api, cli: Do not perform TUF checkin on every Pull or Install, 2024-07-02). The erroneous callback invocation would only be done during an offline update attempt where target ostree data is missing from an bundle.
detsch
force-pushed
the
detsch-remove-leftover-callback
branch
from
bb29a06 to
d81b3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckInCurrent is not supposed to invoke callbacks nor generate events. Issue introduced in e6b6445 (api, cli: Do not perform TUF checkin on every Pull or Install, 2024-07-02).
The erroneous callback invocation would only be done during an offline update attempt where target ostree data is missing from an bundle.