Skip to content

Commit

Permalink
composeappmanager: Remove redundant app install check
Browse files Browse the repository at this point in the history
There is no sense in doing such the primitive check whether an app is
installed in the compose app manager because both the restorable and
composeapp app engines do a proper installation check in the
"appengine->isRunning()" call.

Note: the composeapp app engine will include the installation check in
the following commit.

Signed-off-by: Mike Sul <[email protected]>
  • Loading branch information
mike-sul committed Dec 11, 2024
1 parent d22975e commit da3bfab
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/composeappmanager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,6 @@ ComposeAppManager::AppsContainer ComposeAppManager::getAppsToUpdate(const Uptane
continue;
}

if (!boost::filesystem::exists(cfg_.apps_root / app_name) ||
!boost::filesystem::exists(cfg_.apps_root / app_name / Docker::ComposeAppEngine::ComposeFile)) {
// an App that is supposed to be installed has been removed somehow, let's install it again
apps_to_update.insert(app_pair);
apps_and_reasons[app_pair.first] = "missing installation, to be re-installed";
LOG_INFO << app_name << " will be re-installed";
continue;
}

LOG_DEBUG << app_name << " performing full status check";
if (!app_engine_->isRunning({app_name, app_pair.second})) {
// an App that is supposed to running is not running
Expand Down

0 comments on commit da3bfab

Please sign in to comment.