Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable/disable authentication for READ apis via env variable #78

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Enable/disable authentication for READ apis via env variable #78

merged 1 commit into from
Aug 13, 2024

Conversation

deo002
Copy link
Collaborator

@deo002 deo002 commented Aug 1, 2024

Changes

  • Enable/disable authentication for READ apis via env variable READ_API_AUTHENTICATION_ENABLED. By default, READ apis are not authenticated.
  • Make authentication of relevant apis optional in swagger
  • Create endpoint /apiCollection which returns which endpoints require authentication and which do not.

Submitter Checklist

  • Includes tests (if there is a feature changed/added)
  • Includes docs ( if changes are user facing)
  • I have tested my changes locally.

References

Screenshot from 2024-08-01 14-27-56

@deo002 deo002 requested a review from GMishx August 1, 2024 09:08
GMishx
GMishx requested changes Aug 1, 2024
View reviewed changes
pkg/api/api.go Outdated Show resolved Hide resolved
@deo002 deo002 force-pushed the feat/auth branch 2 times, most recently from e7b2a21 to 4cfe448 Compare August 2, 2024 06:22
@deo002 deo002 requested a review from GMishx August 2, 2024 06:24
GMishx
GMishx requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed.

pkg/api/api.go Outdated Show resolved Hide resolved
@deo002 deo002 requested a review from GMishx August 13, 2024 05:19
GMishx
GMishx approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Tested, working as expected.

@GMishx GMishx merged commit 232c75b into fossology:main Aug 13, 2024
7 checks passed
@GMishx GMishx deleted the feat/auth branch August 13, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deo002 @GMishx