Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license/obligation and user data to audit json response #77

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add license/obligation and user data to audit json response #77

merged 2 commits into from
Aug 1, 2024

Conversation

deo002
Copy link
Collaborator

@deo002 deo002 commented Jul 29, 2024

Changes

  • Adds field 'entity' and 'user' to the Audit Response. Entity can be of type License or Obligation.
  • Removes password from user responses
  • Refactor to remove redundant JWTUser struct

Submitter Checklist

  • Includes tests (if there is a feature changed/added)
  • Includes docs ( if changes are user facing)
  • I have tested my changes locally.

References

image

@deo002 deo002 force-pushed the fix/auditResponse branch from a816f26 to fb1e5aa Compare July 29, 2024 05:32
@deo002 deo002 requested a review from GMishx July 29, 2024 05:33
GMishx
GMishx approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

GMishx
GMishx approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx merged commit b56de6e into fossology:main Aug 1, 2024
7 checks passed
@GMishx GMishx deleted the fix/auditResponse branch August 1, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deo002 @GMishx