Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(license_sorting): Enable sorting in licenses by spdx_id, fullname and shortname #75

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

deo002
Copy link
Collaborator

@deo002 deo002 commented Jul 16, 2024

Changes

  • Enable license sorting by spdx_id, fullname and shortname.

Submitter Checklist

  • Includes tests (if there is a feature changed/added)
  • Includes docs ( if changes are user facing)
  • I have tested my changes locally.

References

image

pkg/api/licenses.go Dismissed Show dismissed Hide dismissed
@deo002 deo002 requested a review from GMishx July 16, 2024 08:35
pkg/api/licenses.go Outdated Show resolved Hide resolved
@deo002 deo002 force-pushed the license_sorting branch from a64665e to 4f9094a Compare July 16, 2024 09:28
@deo002 deo002 requested a review from GMishx July 16, 2024 09:29
pkg/api/licenses.go Outdated Show resolved Hide resolved
@deo002 deo002 force-pushed the license_sorting branch from 4f9094a to e4c4f0e Compare July 17, 2024 10:37
@deo002 deo002 requested a review from GMishx July 17, 2024 10:39
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx merged commit 27ea834 into fossology:main Jul 24, 2024
7 checks passed
@GMishx GMishx deleted the license_sorting branch July 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants