Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports for excluding paths #200

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

SeongjunJo
Copy link
Contributor

Description

  • Exclude files and directories from dependency checking
  • Add test folder and test case.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim
Copy link
Contributor

soimkim commented May 16, 2024

@dd-jy , FL Depdency는 최상단 path의 manifest 파일만 찾기 때문에 특정 path를 제외하는 옵션을 구현하지 않고자 합니다. (불필요)
의견 부탁드립니다.

@dd-jy
Copy link
Contributor

dd-jy commented May 16, 2024

@soimkim, 추후 전체 디렉토리에 대해 찾는 것으로 업데이트 할 수 있고, 이때 node_modules 디렉토리 또는 test 디렉토리 등 manifest file이 존재하는 디렉토리 exclude할 수 있으면 좋을 것으로 보여 FL Dependency에도 추가되는 것이 좋을 것 같습니다.

@soimkim
Copy link
Contributor

soimkim commented May 16, 2024

@dd-jy , 현재는 추가해도 기대하는 동작성이 없습니다.
추후 기능에 활용하시고자 하는 경우 PR 리뷰 후 Merge 부탁드립니다.

@soimkim soimkim added the enhancement [PR/Issue] New feature or request label May 16, 2024
@soimkim
Copy link
Contributor

soimkim commented May 16, 2024

@SeongjunJo, FL util v1.4.43을 릴리즈했습니다.
requirements.txt에서 FL Util 최소 버전을 1.4.43 으로 변경해주십시오.

@dd-jy dd-jy merged commit ccae838 into fosslight:main Jun 5, 2024
6 of 8 checks passed
@SeongjunJo SeongjunJo deleted the exclude_path branch June 5, 2024 13:30
@SeongjunJo SeongjunJo restored the exclude_path branch June 5, 2024 13:30
@SeongjunJo SeongjunJo deleted the exclude_path branch June 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [PR/Issue] New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants