Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer on support page made responsive #3592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajprakash00
Copy link

@rajprakash00 rajprakash00 commented Aug 16, 2020

Fixes #3561

Changes: Fixed the footer on support page which had extra padding due to which route to other links weren't working.

Demo Link: https://pr-3592-fossasia-susi-web-chat.surge.sh

Screenshots:

Before:

susi-before

After:

susi-final

@rajprakash00 rajprakash00 changed the title footer on support page made responsive Footer on support page made responsive Aug 16, 2020
@@ -185,8 +185,7 @@ const SignUpFooter = styled.div`

@media (min-width: 1400px) {
position: relative;
top: 6.25rem;
padding: 0 0 9.375rem 0;
padding: 3.125rem 0 3.125rem 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hard coded solution and doesn't work on various smaller screen sizes. I think you can either add more media queries tracking those breakpoints or find another way around.

Copy link
Author

@rajprakash00 rajprakash00 Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elit-altum I don't think it's hard-coded it was actually already prewritten here(for all sizes) & I just rectified it in min width(for sizes greater than 1400px) since the padding-down & top value was mistakenly more so was overlapping with links,so basically no problem for smaller sizes.(i have checked it too)

@Dilshaad21
Copy link
Member

@rajprakash00 please share the screenshots of the changes you have made.

@rajprakash00
Copy link
Author

@Dilshaad21 I've attached the screenshots
Actually there's no major change to the UI(so i guess screenshot would be of no use) ,that's why I have given the demo link in my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-responsive footer on support page
3 participants