-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer on support page made responsive #3592
base: master
Are you sure you want to change the base?
Conversation
@@ -185,8 +185,7 @@ const SignUpFooter = styled.div` | |||
|
|||
@media (min-width: 1400px) { | |||
position: relative; | |||
top: 6.25rem; | |||
padding: 0 0 9.375rem 0; | |||
padding: 3.125rem 0 3.125rem 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a hard coded solution and doesn't work on various smaller screen sizes. I think you can either add more media queries tracking those breakpoints or find another way around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elit-altum I don't think it's hard-coded it was actually already prewritten here(for all sizes) & I just rectified it in min width(for sizes greater than 1400px) since the padding-down & top value was mistakenly more so was overlapping with links,so basically no problem for smaller sizes.(i have checked it too)
@rajprakash00 please share the screenshots of the changes you have made. |
@Dilshaad21 I've attached the screenshots |
Fixes #3561
Changes: Fixed the footer on support page which had extra padding due to which route to other links weren't working.
Demo Link: https://pr-3592-fossasia-susi-web-chat.surge.sh
Screenshots:
Before:
After: