Merge pull request #4209 from fossasia/development

fossasia · Mar 9, 2020 · 0de77a4 · 0de77a4
2 parents b85fa50 + 99b652a
commit 0de77a4
Show file tree

Hide file tree

Showing 54 changed files with 1,537 additions and 1,353 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -62,7 +62,7 @@ module.exports = {
     ],
     'max-len': 'off',
     'no-console': ["error", { allow: ["warn", "error"] }],
-    'prefer-template': 'error',
+    'prefer-template': 'off',
     'camelcase': 'off',
     'new-cap': 'off',
     'eqeqeq': ['error', 'smart'],

diff --git a/app/components/account/danger-zone.js b/app/components/account/danger-zone.js
@@ -37,7 +37,8 @@ export default Component.extend({
             id: 'account_Delete'
           });
         })
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while deleting account', e);
           this.notify.error(this.l10n.t('An unexpected error has occurred.'), {
             id: 'account_del_error'
           });

diff --git a/app/components/account/email-preferences-section.js b/app/components/account/email-preferences-section.js
@@ -9,7 +9,8 @@ export default Component.extend({
             id: 'email_notif'
           });
         })
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while updating email notifications.', e);
           emailPreference.rollbackAttributes();
           this.notify.error(this.l10n.t('An unexpected error occurred.'), {
             id: 'email_error'

diff --git a/app/components/events/view/export/api-response.js b/app/components/events/view/export/api-response.js
@@ -38,7 +38,8 @@ export default Component.extend({
         json = JSON.stringify(json, null, 2);
         this.set('json', htmlSafe(syntaxHighlight(json)));
       })
-      .catch(() => {
+      .catch(e => {
+        console.error('Error while fetching export JSON from server', e);
         this.notify.error(this.l10n.t('Could not fetch from the server'), {
           id: 'server_fetch_error'
         });

diff --git a/app/components/events/view/export/download-common.js b/app/components/events/view/export/download-common.js
@@ -39,13 +39,15 @@ export default Component.extend({
               id: 'task_progress'
             });
           } else {
+            console.error('Event exporting task failed', exportJobStatus);
             this.set('eventExportStatus', exportJobStatus.state);
             this.notify.error(this.l10n.t('Task failed.'), {
               id: 'task_fail'
             });
           }
         })
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while exporting event', e);
           this.set('eventExportStatus', 'FAILURE');
           this.notify.error(this.l10n.t('Task failed.'), {
             id: 'task_failure'
@@ -64,7 +66,8 @@ export default Component.extend({
         .then(exportJobInfo => {
           this.requestLoop(exportJobInfo);
         })
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while starting exporting job', e);
           this.set('isLoading', false);
           this.notify.error(this.l10n.t('Unexpected error occurred.'), {
             id: 'unexpected_down_error'

diff --git a/app/components/events/view/export/download-zip.js b/app/components/events/view/export/download-zip.js
@@ -16,7 +16,7 @@ export default class extends Component {
         id: 'export_succ'
       });
     } catch (e) {
-      console.error(e);
+      console.error('Error while downloading event zip', e);
       this.notify.error(this.l10n.t(e), {
         id: 'err_down'
       });

diff --git a/app/components/events/view/overview/manage-roles.js b/app/components/events/view/overview/manage-roles.js
@@ -32,7 +32,8 @@ export default Component.extend({
             id: 'man_role'
           });
         })
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while updating role invite', e);
           this.notify.error(this.l10n.t('Oops something went wrong. Please try again'), {
             id: 'man_role_err'
           });
@@ -50,7 +51,8 @@ export default Component.extend({
           });
           this.get('data.roleInvites').removeObject(invite);
         })
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while deleting role invite', e);
           this.notify.error(this.l10n.t('Oops something went wrong. Please try again'), {
             id: 'err_man_role'
           });

diff --git a/app/components/forms/admin/settings/system/mail-settings/test-email-form.js b/app/components/forms/admin/settings/system/mail-settings/test-email-form.js
@@ -40,7 +40,7 @@ export default Component.extend(FormMixin, {
             });
           })
           .catch(e => {
-            console.warn(e);
+            console.error('Error while sending test email', e);
             this.notify.error(this.l10n.t('An unexpected error has occurred'), {
               id: 'test_mail_err'
             });

diff --git a/app/components/forms/admin/settings/ticket-fees-form.js b/app/components/forms/admin/settings/ticket-fees-form.js
@@ -40,7 +40,8 @@ export default Component.extend({
             id: 'fee_delete_succ'
           });
         })
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while deleting ticket', e);
           this.notify.error(this.l10n.t('Oops something went wrong. Please try again'), {
             id: 'fee_err'
           });

diff --git a/app/components/forms/login-form.js b/app/components/forms/login-form.js
@@ -61,8 +61,10 @@ export default class extends Component.extend(FormMixin) {
         }
       } catch (e) {
         if (e.json && e.json.error) {
+          console.warn('Error while authentication', e);
           this.set('errorMessage', this.l10n.tVar(e.json.error));
         } else {
+          console.error('Error while authentication', e);
           this.set('errorMessage', this.l10n.t('An unexpected error occurred.'));
         }
       }
@@ -89,6 +91,7 @@ export default class extends Component.extend(FormMixin) {
             id: 'error_server_msg'
           });
         } else {
+          console.error('Error while facebook authentication', e);
           this.notify.error(this.l10n.t('An unexpected error has occurred'), {
             id: 'unexpect_error'
           });

diff --git a/app/components/forms/reset-password-form.js b/app/components/forms/reset-password-form.js
@@ -60,7 +60,8 @@ export default Component.extend(FormMixin, {
               });
               this.router.transitionTo('login');
             })
-            .catch(() => {
+            .catch(e => {
+              console.error('Error while resetting password', e);
               this.set('errorMessage', this.l10n.t('An unexpected error occurred.'), {
                 id: 'reset_unexpect'
               });
@@ -86,8 +87,10 @@ export default Component.extend(FormMixin, {
             })
             .catch(reason => {
               if (reason && Object.prototype.hasOwnProperty.call(reason, 'errors') && reason.errors[0].status === 404) {
+                console.warn('Reset Password: No user account found', reason);
                 this.set('errorMessage', this.l10n.t('No account is registered with this email address.'));
               } else {
+                console.error('Error while submitting reset password', reason);
                 this.set('errorMessage', this.l10n.t('An unexpected error occurred.'));
               }
             })

diff --git a/app/components/forms/user-payment-info-form.js b/app/components/forms/user-payment-info-form.js
@@ -106,6 +106,7 @@ export default class extends Component.extend(FormMixin) {
           id: 'bill_det_updated'
         });
       } catch (error) {
+        console.error('Error while updating billing details', error);
         this.authManager.currentUser.rollbackAttributes();
         this.notify.error(this.l10n.t('An unexpected error occurred'), {
           id: 'bill_det_unexpect'

diff --git a/app/components/forms/user-profile-form.js b/app/components/forms/user-profile-form.js
@@ -67,7 +67,8 @@ export default Component.extend(FormMixin, {
               id: 'profi_update'
             });
           })
-          .catch(() => {
+          .catch(e => {
+            console.error('Error while  updating profile.', e);
             this.get('authManager.currentUser').rollbackAttributes();
             this.notify.error(this.l10n.t('An unexpected error occurred'), {
               id: 'profi_error'

diff --git a/app/components/forms/wizard/basic-details-step.js b/app/components/forms/wizard/basic-details-step.js
@@ -96,7 +96,10 @@ export default Component.extend(FormMixin, EventWizardMixin, {
     later(this, () => {
       try {
         this.set('subTopic', null);
-      } catch (ignored) { /* To suppress error thrown in-case this gets executed after component gets destroy */ }
+      } catch (ignored) {
+        /* To suppress error thrown in-case this gets executed after component gets destroy */
+        console.warn('Error setting subTopic to null', ignored);
+      }
     }, 50);
     if (!this.get('data.event.topic')) {
       return [];
@@ -403,6 +406,7 @@ export default Component.extend(FormMixin, EventWizardMixin, {
           }));
         })
         .catch(error => {
+          console.error('Error while setting stripe authorization in event', error);
           this.notify.error(this.l10n.t(`${error.message}. Please try again`), {
             id: 'basic_detail_err'
           });

diff --git a/app/components/modals/change-image-modal.js b/app/components/modals/change-image-modal.js
@@ -12,7 +12,8 @@ export default ModalBase.extend({
               id: 'placeholder_sav'
             });
           })
-          .catch(() => {
+          .catch(e => {
+            console.error('Error while saving placeholder.', e);
             this.notify.error(this.l10n.t('An unexpected error has occurred. Placeholder not saved.'), {
               id: 'placeholder_err'
             });

diff --git a/app/components/modals/modal-base.js b/app/components/modals/modal-base.js
@@ -36,7 +36,10 @@ export default UiModal.extend({
     this._super(...arguments);
     try {
       $(this.element).modal('refresh');
-    } catch (ignored) { /* ignored exception */ }
+    } catch (ignored) {
+      /* ignored exception */
+      console.warn('Error refreshing modal', ignored);
+    }
   },
 
 

diff --git a/app/components/notification-dropdown.js b/app/components/notification-dropdown.js
@@ -24,7 +24,8 @@ export default Component.extend({
             id: 'not_read_succ'
           });
         })
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while marking notifications as read.', e);
           this.notify.error(this.l10n.t('An unexpected error occurred.'), {
             id: 'not_read_error'
           });

diff --git a/app/components/public/ticket-list.js b/app/components/public/ticket-list.js
@@ -119,6 +119,7 @@ export default Component.extend(FormMixin, {
           this.set('invalidPromotionalCode', false);
         });
       } catch (e) {
+        console.error('Error while applying access code', e);
         this.set('invalidPromotionalCode', true);
       }
       try {
@@ -148,7 +149,7 @@ export default Component.extend(FormMixin, {
           this.set('invalidPromotionalCode', true);
         }
       } catch (e) {
-        console.warn(e);
+        console.error('Error while applying discount code as promo code', e);
         if (this.invalidPromotionalCode) {
           this.set('invalidPromotionalCode', true);
         }

diff --git a/app/components/ui-table-server.js b/app/components/ui-table-server.js
@@ -162,7 +162,8 @@ export default ModelsTable.extend({
       }
       store.query(modelName, query)
         .then(newData => setProperties(this, { isLoading: false, isError: false, filteredContent: newData }))
-        .catch(() => {
+        .catch(e => {
+          console.error('Error while querying data in UI Table', e);
           if (!this.isDestroyed) {
             setProperties(this, { isLoading: false, isError: true });
           }

diff --git a/app/components/unverified-user-message.js b/app/components/unverified-user-message.js
@@ -28,6 +28,7 @@ export default Component.extend({
           this.set('isMailSent', true);
         })
         .catch(error => {
+          console.error('Error while sending verification email', error, error.error);
           if (error.error) {
             this.notify.error(this.l10n.t(error.error), {
               id: 'ver_mail_serv_error'

diff --git a/app/components/widgets/forms/file-upload.js b/app/components/widgets/forms/file-upload.js
@@ -28,7 +28,8 @@ export default Component.extend({
           id: 'file_upload_succ'
         });
       })
-      .catch(() => {
+      .catch(e => {
+        console.error('Error while upload file', e);
         this.notify.error(this.l10n.t('Oops something went wrong. Please try again'), {
           id: 'file_upload_err'
         });
@@ -47,6 +48,7 @@ export default Component.extend({
         };
         reader.readAsDataURL(files[0]);
       }).catch(error => {
+        console.error('Error while reading file', error);
         this.notify.error(error, {
           id: 'file_upload_err_1'
         });

diff --git a/app/components/widgets/forms/image-upload.js b/app/components/widgets/forms/image-upload.js
@@ -34,7 +34,8 @@ export default Component.extend({
         this.set('uploadingImage', false);
         this.set('imageUrl', image.url);
       })
-      .catch(() => {
+      .catch(e => {
+        console.error('Error while uploading and setting image URL', e);
         this.set('uploadingImage', false);
         this.set('errorMessage', this.i18n.t('An unexpected error occurred.'));
       });
@@ -56,6 +57,7 @@ export default Component.extend({
         reader.readAsDataURL(files[0]);
 
       }).catch(error => {
+        console.error('Error while image reading and cropping', error);
         this.notify.error(error, {
           id: 'unexpected_image_upload_1'
         });

diff --git a/app/controllers/account/password.js b/app/controllers/account/password.js
@@ -21,6 +21,7 @@ export default class extends Controller {
           });
       })
       .catch(error => {
+        console.error('Error while updating password', error);
         if (error.errors) {
           this.notify.error(this.l10n.t(`${error.errors[0].detail}`),
             {

diff --git a/app/controllers/account/profile.js b/app/controllers/account/profile.js
@@ -11,7 +11,8 @@ export default class extends Controller {
         {
           id: 'cont_info_upd'
         });
-    }  catch (error) {
+    } catch (error) {
+      console.error('Error while updating contact info', error);
       this.notify.error(this.l10n.t(error.message),
         {
           id: 'cont_upd_error'

diff --git a/app/controllers/admin/content/events.js b/app/controllers/admin/content/events.js
@@ -15,6 +15,7 @@ export default class extends Controller {
       this.set('disableEventSubtopic', false);
       this.set('currentTopicSelected', topic);
     } catch (e) {
+      console.error('Error while updating subtopics', e);
       this.notify.error(this.l10n.t('An unexpected error has occurred. SubTopics not loaded.'),
         {
           id: 'subtop_error'
@@ -45,7 +46,8 @@ export default class extends Controller {
             id: 'event_prop_del'
           });
       })
-      .catch(() => {
+      .catch(e => {
+        console.error('Error while deleting ' + modelName, e);
         this.notify.error(this.l10n.t('An unexpected error has occurred. Event Type was not deleted.'),
           {
             id: 'event_type_error'
@@ -68,7 +70,8 @@ export default class extends Controller {
             id: 'mode_add_succ'
           });
       })
-      .catch(() => {
+      .catch(e => {
+        console.error('Error while adding ' + camelCasedValue, e);
         this.notify.error(this.l10n.t(`An unexpected error has occurred. ${startCase(camelCasedValue)} not saved.`),
           {
             id: 'mode_err_succ'

diff --git a/app/controllers/admin/content/index.js b/app/controllers/admin/content/index.js
@@ -13,7 +13,8 @@ export default class extends Controller {
             id: 'social_link_upd'
           });
       })
-      .catch(() => {
+      .catch(e => {
+        console.error('Error updating social links', e);
         this.notify.error(this.l10n.t('An unexpected error has occurred. Social links not saved.'),
           {
             id: 'unex_social_error'

diff --git a/app/controllers/admin/content/pages.js b/app/controllers/admin/content/pages.js
@@ -32,7 +32,8 @@ export default class extends Controller {
             id: 'page_detail_succ'
           });
       })
-      .catch(() => {
+      .catch(e => {
+        console.error('Error saving page details', e);
         this.notify.error(this.l10n.t('An unexpected error has occurred. Page Details not saved.'),
           {
             id: 'page_detail_del'

diff --git a/app/controllers/admin/content/translations.js b/app/controllers/admin/content/translations.js
@@ -19,7 +19,7 @@ export default class extends Controller {
           id: 'zip_generated_succ'
         });
     } catch (e) {
-      console.warn(e);
+      console.error('Error downloading translation zip', e);
       this.notify.error(this.l10n.t('Unexpected error occurred.'),
         {
           id: 'zip_error'