Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated namespaces for Thrift #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Generated namespaces for Thrift #52

wants to merge 2 commits into from
+349 −4

Commits on May 22, 2019

  1. Use const_get for constant look up 

    This is a bit easier to automatically namespace
    @pointlessone
    pointlessone committed May 22, 2019
    Configuration menu
    Copy the full SHA
    283df1e View commit details
    Browse the repository at this point in the history

  2. Namespace bare Thrift constants 

    There's a number of rather generically named classes in the generated
Thrift files. There's a high chance of name collision between those
classes and user code.

To avoid the issue those constants are namespaced during the gem
packaging.
    @pointlessone
    pointlessone committed May 22, 2019
    Configuration menu
    Copy the full SHA
    c1cebbc View commit details
    Browse the repository at this point in the history