Sync Resonance fork with latest Robyn #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ts_validation.png - pareto_clusters_detail.png
- scale onepager height based on nr of channel - fix one typo
Fix plotting issues
- date_range in robyn_response should only refer to modelling window, not the total dataset. - bump up dev version
…ering by hyperparameters
…t scenarios for same model
…eate dir when it doesn't exist
- TSIA - typo in demo
Bundle changes
- when plot_folder & plot_folder_sub are null, dir will follow json or OutoutCollect
feat: enable plot_folder for allocator
This allows customisation of optimisation weights among objective functions. default is even weight c(1, 1). It also allows 0 weight, equal to removing an objective function. check function needs to be amended, because the values needs to be >=0 and the same length as obj.fun count
feat and fix: InputCollect use case for robyn_recreate() + organic_vars added to prophet decomp
- Fix: wrapped `pareto_clusters_detail.png` creation with try() to skip if too large + don't fail `robyn_outputs()` long runs - Feat: new `max_clusters` param to avoid too many clusters. Default value set to 10 - Fix: warning saying Unknown or uninitialised column: nrmse_test
…941) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ite (#943) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Added "@Serializer json list(digits = 20, na = 'null')" for all post methods. This decorator prevents 1. rounding of a few, and 2. deletion of columns where the value are NA in the response of API.
- As in issue #971, fixed the check error when using penalty and refresh. - bump up version
Fixed error when ts_validation is false.
After testing with few beta users on bl01 branch, it's good to land. - fix: several bugs when refreshing with `robyn_refresh()` - non-existing folders, cluster = FALSE, CSV exports, ts_validation, window_end inherited - fix: penalties hyperparameters checked correctly when recreating a model that used penalization - fix: similar plotting scales for refresh plots when performance is too large to improve readability (`refresh_plots_json()`) - feat: new `add_data` parameter in `robyn_write()` to include raw data. When used, `dt_input` is not required to recreate model - feat: improved chain logic on refresh models. If user is not following chained directories but models are available in `plot_folder`, they will be loaded and used - feat: recreate InputCollect when RobynModel-models.json provided (no selected model) This is version 3.10.7 but will be CRAN's 3.11.0 if no bugs or issues are reported within a week or so.
- Shape and scale can be set / fixed to 0, meaning no adstock.
… upper constraints fix when higher than mean (#974) * fix: refresh hyps check #960 + use data available in json * fix: update based on gz's comments * fix: fixed penalties and other fixed hyps on refreshing models * fix: refresh plot when chain is broken + feat: new bounds_freedom parameter to overwrite default calculation * fix: import and store original model when not in original plot_dir * recode: applied styler::tidyverse_style() to clean code for CRAN * fix: paid_media_total calc * fix: print ExportedModel only when available * fix: deal with negative trend - negative trend is not interpretable for MMM - force negative coef when trend is negative to get positive decomp * fix: upper constraint issue on BA for target_efficiency and weibull adstock feat: instead of Inf, use channel_constr_up, which by default is 10 for target_efficiency * fix: reverse wrong bounds update in refresh_hyps The refactoring of initBounds & listOutputPrev in refresh_hyps was wrong in 774c18d * recode: apply styler::tidyverse_style() --------- Co-authored-by: gufengzhou <[email protected]>
Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.9...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ns (#1013) * fix: skip other hyperparameters from old flow to replace exposure hyps with spend hyps #1003 * feat: new robyn_immcarr() + export more functions * fix: missing rbind line added * fix: group warning and repeated vals * recode: show Immediate on the left and Carryover on the right in op plot
- Added the robyn_refresh endpoint in robynapi_endpoint.R. - Added an example to call robyn_refresh in robyn_python_notebook.ipynb. - Updated write_robynmodel() in python_helper.py to default to outputting JSON to plot_folder if no path is specified. - Modified variable names.
Added robyn_refresh endpoint
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.2 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.88.2...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.19.2...4.21.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 0 (#1061) * feat: cleaner decomp_plot() using cols instead of areas + ref line in 0 * fix: sort variables by baseline first & amount of absolute impact + exclude 0 impact from legend/plot * fix: baseline and then rest of variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Robyn
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist: