-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CI via GH actions #129
Conversation
I would do codecov.io instead of coveralls and for PyPi we can copy this https://github.com/gnikit/fortls/blob/master/.github/workflows/python-publish.yml but we will have to get @pseewald to upload the tokens as secrets to the repo. |
Also, we might want to consider first swapping to setup.cfg, pyproject.toml, setup.py 3-file stubs and reshaping the testing (not in this PR though) |
It looks like this project originally used coveralls, I would be fine with switching to codecov as well. @pseewald any preference?
Let's get the CI running first before we start changing things. |
We don't have to fetch the tarballs, we can just clone I recon. |
They are fetched via git-archive tarballs from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we need to upload the Secrets but that is only relevant for Publishing
uses: pypa/gh-action-pypi-publish@master | ||
with: | ||
user: __token__ | ||
password: ${{ secrets.TEST_PYPI_API_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pseewald If you can generate the tokens from PyPi Test and PyPi and store them as secrets with the name TEST_PYPI_API_TOKEN
and PYPI_API_TOKEN
, then this action can be used for publishing i.e. no need to use twine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with that process. Alternatively, we move fprettify soon to @fortran-lang, then you can take care of this as well (if you agree)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a nice way to publish and upload packages to PyPi via the GitHub UI. It calls twine
in the background so it needs a valid PyPi token to successfully upload the package to pseewald
This is a similar example to how the Language Server does it: https://github.com/gnikit/fortls/blob/25b793c224ce888aa533928e75386fba565d4942/.github/workflows/python-publish.yml#L34-L46
I am happy for fprettify to move to fortran-lang. Still in that case the publishing issue would persist. You would have to add the Fortran-lang PyPi account as a maintainer or owner to be able to publish the package on PyPi.
@awvwgk @gnikit Thanks a lot of taking care of this, great work! Sorry for replying late.
I have no preference due to lack of experience regarding these tools, please use whatever you prefer.
Sorry for this cumbersome mechanism, I'll soon make a pr for #140 where I change the way external Fortran code is added for tests. I also suggest that we use the official repositories instead of custom forks (I'll also take care of this in #140). |
Thanks for taking care of this @pseewald, that's great! |
TODO
Closes #128