Tooltip component #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spli02
requested changes
Oct 21, 2024
| * Tooltip title. Can be optionally used as tooltip children. | ||
| */ | ||
| export const TooltipTitle = ({ children }: TooltipTitleProps) => ( | ||
| <h1 className={cl['bk-tooltip--title']}>{children}</h1> |
There was a problem hiding this comment.
I think class name bk-tooltip--title should be bk-tooltip__title in BEM (https://getbem.com/naming/).
The same goes for bk-tooltip--alert and bk-tooltip--icon in the code below.
| @@ -26,7 +32,44 @@ export const Tooltip = ({ unstyled = false, ...propsRest }: TooltipProps) => { | |||
| bk: true, | |||
| [cl['bk-tooltip']]: !unstyled, | |||
| 'bk-body-text': !unstyled, | |||
| [cl['bk-tooltip--size-small']]: size === 'small', | |||
There was a problem hiding this comment.
bk-tooltip--size-small can be bk-tooltip--small if we follow the same way as different components like bk-spinner--small or bk-link--small format.
| <h1 className={cl['bk-tooltip--title']}>{children}</h1> | ||
| ); | ||
|
|
||
| export type TooltipItemProps = React.PropsWithChildren<ComponentProps<'h1'> & { |
There was a problem hiding this comment.
ComponentProps<'h1'> should be ComponentProps<'p'> as TooltipItem has p element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.