Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9166 Fixed alignment for the buttons in formbuilder #259

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

antonSoftensity
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9166

Description

What changed?

Use this section to provide a summary description of the changes you've made

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

Use this section to list any dependent changes/PRs in other Form.io modules

How has this PR been tested?

Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Even though this is a simple change, let's get in the habit of filling out the PR template.
  2. This change seems fine, but is there any indication as to why it changed from 4.x to 5.x? Is there a gap in our USWDS template that needs to be addressed rather than an ad-hoc change to the SaSS?

@antonSoftensity
Copy link
Contributor Author

@brendanbond it seems like the button classes were changed when USWDS was upgraded to 3.0, which led to that issue. So I believe this particular change is needed in our override stylesheet.

@brendanbond brendanbond merged commit 6415e9c into master Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants