Do not distribute Cython-generated C++ sources in binary wheels #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would argue that including the Cython-generated
.cppC++ sources in the binary wheels is not likely to be useful to end users, and dropping them greatly decreases the size of the binary wheels. In my testing, the.whlfile goes from 440K to 176K, and the uncompressed installation goes from 2.3M to 528K.The
.pyxand.pxdfiles aren’t strictly necessary either, but they are much smaller, and they do help provide better tracebacks. There’s a discussion of this topic in aio-libs/aiohttp#6399, where I proposed a similar change in aiohttp.This change does not affect the contents of the sdist.