Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the changes required to make all the build images CI workflows pass in terms of building the images, and verifying they are all upgraded to LLVM 14. A successful run can be seen here. The PR also includes some small quality of life improvements in terms of code formatting.
These changes were made to support RedBPF issue #314. The specific changes include:
Set image name lowercase
steps in the publish workflow to lowercaseREDBPF_IMAGE_NAME
. This was required so that anyone like myself who forks and has uppercase letters in their GitHub username can produce docker images with a valid name.apt-get install
blocks to have one package per line to make visual comparison across files easierllvm14
llvm-config-14
to/usr/bin/llvm-config
llvm-config --version
check script from 13 to 14max_parallel_download=20
andfastestmirror=True
to the Fedoradnf.conf
to speed up image build timesemerge-websync
to Gentoo to overcome spurious network errors when buildingemerge app-portage/mirrorselect
andmirrorselect -s3 -b10 -D -c USA
to Gentoo to hopefully speed up build times. I not strictly sure this is necessary withemerge-webrsync
but my Gentoo was non-existent prior to this effort 😺What I did not do was devise a way to parameterize the
llvm
version, which seems like a good idea in terms of future maintenance. I can do that in a subsequent PR or this one if desired.