Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pdf/a compliance of attachments #1562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

florianbepunkt
Copy link

Fixes part of #1561

I followed the contributing guide, but this did not work. All tests failed due to some jest config problem:

Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

Is the contributing guide up-to-date?

@liborm85
Copy link
Collaborator

liborm85 commented Nov 2, 2024

Fixed rendering diff in unit tests by commit 3a6977e. Update PR on master upstream.

@liborm85
Copy link
Collaborator

liborm85 commented Nov 2, 2024

I don't know why your local Jest is failing. Commands in contributing guide are correct.

@florianbepunkt
Copy link
Author

Rebased based on origin/master.

Regarding the tests: I don't know. There is yarn.lock in the repo, but contributing guide says npm. Jest is complaining about ESM modules. I cloned the master branch, run npm install, npm run build and npm run test. So no changes on my end, just followed the instructions.

@blikblum
Copy link
Member

blikblum commented Nov 7, 2024

The tests are running fine on CI.

The object tests need to be adapted to handle the added field. See https://github.com/foliojs/pdfkit/actions/runs/11642384173/job/32422370876?pr=1562

@blikblum
Copy link
Member

blikblum commented Nov 7, 2024

There is yarn.lock in the repo, but contributing guide says npm.

It should use yarn. the contributing must be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants