Generate ToUnicodeMap bfrange in multiple ranges (#1498) #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A bfrange line can have only 256 glyphs. Let's split the glyphs into multiple lines. Note: This may be not correctly at all. According to the spec, we may have at most 100 lines (256*100=25600 glyphs). I am not sure if any PDF viewer in real world implements this limit, but hey... that's the spec. I am not a PDF expert - any help is welcome! |
|
test-fixed.pdf |
|
Please add a changelog entry |
orzFly
force-pushed
the
patch-tounicodemap
branch
from
f4dd1a8
to
149d514
Compare
I was thinking about how to add the unit test. Both unit test and changelog entry are added now. |
orzFly
force-pushed
the
patch-tounicodemap
branch
from
149d514
to
bcaf565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix of #1498
Checklist: