MODDCB-83 #64
Merged
MODDCB-83 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and added personal object while creating user
# Conflicts: # src/main/resources/swagger.api/schemas/CirculationRequest.yaml # src/main/resources/swagger.api/schemas/User.yaml
…aiting Pickup in borrower role
# Conflicts: # src/test/java/org/folio/dcb/service/BorrowingPickupLibraryServiceTest.java
gurleenkaurbp
approved these changes
Dec 12, 2023
SinghAdes
approved these changes
Dec 12, 2023
# Conflicts: # src/main/java/org/folio/dcb/controller/ExceptionHandlingController.java # src/main/java/org/folio/dcb/service/impl/TransactionsServiceImpl.java # src/test/java/org/folio/dcb/service/TransactionServiceTest.java
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of the PR is to implement https://issues.folio.org/browse/MODDCB-83
Approach
Using chain of responsibility pattern, for lending and borrowing flow, we identify the list of statuses that we need to do the transition. Once we get the list of statuses, we call the update method for every status.
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.