MODDCB-49 #46
Merged
MODDCB-49 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DDCB-49 # Conflicts: # src/main/java/org/folio/dcb/listener/kafka/CirculationEventListener.java # src/main/java/org/folio/dcb/service/impl/PickupLibraryServiceImpl.java
…DDCB-49 # Conflicts: # src/main/java/org/folio/dcb/service/impl/BorrowingPickupLibraryServiceImpl.java # src/main/java/org/folio/dcb/utils/DCBConstants.java
…DDCB-49 # Conflicts: # src/main/java/org/folio/dcb/service/impl/BorrowingPickupLibraryServiceImpl.java # src/main/java/org/folio/dcb/service/impl/CustomTenantService.java # src/main/java/org/folio/dcb/service/impl/PickupLibraryServiceImpl.java # src/main/java/org/folio/dcb/utils/DCBConstants.java
…DDCB-49 # Conflicts: # src/main/java/org/folio/dcb/service/impl/LendingLibraryServiceImpl.java
# Conflicts: # src/test/resources/mappings/cancellation.json
DmytroBykov1
suggested changes
Nov 20, 2023
src/main/java/org/folio/dcb/service/impl/CirculationRequestServiceImpl.java
Outdated
Show resolved
Hide resolved
Vignesh-kalyanasundaram
requested changes
Nov 20, 2023
src/main/java/org/folio/dcb/listener/kafka/CirculationEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/dcb/service/CirculationRequestService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/dcb/service/impl/CirculationRequestServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/resources/db/changelog/changes/create-transaction-table.xml
Outdated
Show resolved
Hide resolved
src/main/resources/db/changelog/changes/create-transaction-table.xml
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/dcb/listener/kafka/CirculationCheckInEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/dcb/service/impl/CustomTenantService.java
Outdated
Show resolved
Hide resolved
MagzhanArtykov
requested review from
gurleenkaurbp,
DmytroBykov1 and
Vignesh-kalyanasundaram
…DDCB-49 # Conflicts: # src/main/java/org/folio/dcb/service/impl/BorrowingLibraryServiceImpl.java
…DDCB-49 # Conflicts: # src/main/java/org/folio/dcb/service/impl/BorrowingLibraryServiceImpl.java
src/main/java/org/folio/dcb/service/impl/BaseLibraryService.java
Outdated
Show resolved
Hide resolved
…DDCB-49 # Conflicts: # src/test/java/org/folio/dcb/service/BorrowingLibraryServiceTest.java
|
Kudos, SonarCloud Quality Gate passed! |
SinghAdes
approved these changes
Nov 21, 2023
Vignesh-kalyanasundaram
approved these changes
Nov 22, 2023
gurleenkaurbp
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers: MODDCB-49
Purpose
Main purpose of this PR is to implement support of DCB transaction cancellation
Approach
If a user cancels DCB Page request in Lending library, then the status of DCB transaction should be updated to CANCELLED.
DCB propagates CANCELLED transaction status to Borrowing/Pickup libraries.
Learning
Please refer to: CIRCSTORE-463