RANCHER-1334 Eureka related images into eureka-platform.json file for further Rancher deployments #154
Conversation
eldiiar-duishenaliev
requested review from
funkymalc,
dcrossleyau,
wafschneider and
ihardy
as code owners
|
In the future please do not include code formatting changes in the same pull-request. Doing such obscures the real changes. |
|
Please refer to the Jira ticket if possible. |
|
What does "EPC" mean in the commit message? |
|
Thanks for explaining that this was tested. |
Hello Sir, |
This activity is a part of story: https://folio-org.atlassian.net/browse/RANCHER-1334 |
Sure Sir, sorry, that's a bad habit to make formatting in whole file. |
dcrossleyau
changed the title
|
Thanks for explaining. No need for Sure, do cleanup -- just not in the same PR for review please. It would be easy for people to overlook something important. |
There was a problem hiding this comment.
In general, this looks OK to me. If I understand it correctly, the eureka.json file in the snapshot branch of platform-complete will be updated for every release and every commit to the default branch if the module is already in the eureka.json file.
This is not my code, so I'd like @funkymalc or @dcrossleyau to look at this before approval.
There was a problem hiding this comment.
Can you please confirm that there are only formatting changes in this file?
There was a problem hiding this comment.
There is a one-line relevant change in each of the Docker-related files to call the updateEurekaFile script.
|
Oops, sorry, @dcrossleyau, I didn't realize you had already reviewed, and had already addressed my main concern (formatting changes obscuring the actual code changes). Go forth! |
TESTED IN: https://jenkins-aws.indexdata.com/job/folio-org/job/mod-consortia-keycloak/job/dockerImageBuild/13/