Correct bug detecting content type and parsing JSON responses #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigitallyBorn
force-pushed
the
rs-json-bug
branch
from
30e8c06
to
e773454
Compare
DigitallyBorn
commented
Feb 26, 2019
| @@ -316,7 +321,7 @@ def request(params) | |||
| end | |||
| end | |||
|
|
|||
| response.body = Fog::JSON.decode(response.body) if !response.body.empty? && response.get_header('Content-Type') == 'application/json' | |||
There was a problem hiding this comment.
This value often comes back as application/json; charset=utf-8which fails the exact-string matching used before.
This is likely a breaking bug fix, since requests will now _correctly_ parse the response body as json and return a hash, instead of returning the body as a string. Fixes fog#34
DigitallyBorn
force-pushed
the
rs-json-bug
branch
from
eea7907
to
3acf215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely a breaking bug fix, since requests will now correctly parse the response body as json and return a hash, instead of returning the body as a string.
Fixes #34