Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting for toggling Link Reference generation. #227

Closed

Conversation

jessems
Copy link

@jessems jessems commented Aug 21, 2020

Adds a setting for toggling Link References. Defaults to "true" as per specifications in the roadmap.

Note, this doesn't affect the janitor script. When you run the janitor with the setting set to false, Link References will still be generated.

Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except you maybe want to add some docs to link-reference-definitions

@jevakallio
Copy link
Collaborator

@jessems thanks for this suggestion! I'm not able to accept this PR, since removing link reference definitions affects many other places in the codebase (for example, the janitor, the CLI, documentation, etc.) and this PR does only a small fraction of the work.

We may add support for this feature down the line as we have a better understanding on how we're going to manage link targeting. There are some ongoing plans in:

In the meantime, if you don't need the markdown compatibility links, you can disable the Foam extension and just use the Markdown Links and Markdown Notes extensions as you were.

@jevakallio jevakallio closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants